Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hifi-decode: Better resampling, Spectral Noise Reduction, Multi processing #183

Merged
merged 12 commits into from
Jan 30, 2025

Conversation

eshaz
Copy link

@eshaz eshaz commented Jan 27, 2025

Noise reduction / Re-sampling updates

  • Add spectral noise reduction before deemphasis to remove FM noise
  • Use sinc converter for resampling in audio chain to reduce resampling artifacts (controlled via options)

Multi-processing updates

  • Refactor thread pools into process pools for better multi threading. This helps to offset the extra processing time for the better resampling methods.

Other Updates

  • Fix hifi-decode deemphasis and weighting filters to use closer bandwidth to spec, vs. using q factor
  • Add ability to specify bandwidth and slope to vhsdecode/addons/FMdeemph.py shelf filter
  • Refactor post processing audio chain

New Options

  • Add --NR_spectral_amount option to control amount of spectral noise reduction.
    • 0 to disable
    • 1 for full spectral noise reduction
    • default: 0.4
  • Add --resampler_quality option to enable better quality resamplers. This reduces noise at the expense of processing time.
    • low, medium, high
    • default: high

@eshaz eshaz changed the title Hifi Decode: add light spectral noise reduction before deemphasis hifi-decode: Better resampling, Spectral Noise Reduction Jan 29, 2025
@eshaz eshaz changed the title hifi-decode: Better resampling, Spectral Noise Reduction hifi-decode: Better resampling, Spectral Noise Reduction, Multi processing Jan 30, 2025
@eshaz eshaz marked this pull request as ready for review January 30, 2025 03:05
@eshaz
Copy link
Author

eshaz commented Jan 30, 2025

The GUI should probably be checked before this gets merged in.

@eshaz
Copy link
Author

eshaz commented Jan 30, 2025

Found a small bug, setting back to draft while I fix it.

@eshaz eshaz marked this pull request as draft January 30, 2025 13:13
@eshaz eshaz marked this pull request as ready for review January 30, 2025 18:13
@harrypm harrypm merged commit ce92544 into oyvindln:vhs_decode Jan 30, 2025
@eshaz eshaz deleted the hifi-decode-spectral-nr branch January 30, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants