Make the encoder for the cursors of the edges of a connection customizable #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
reviewed
May 23, 2020
mcg-web
reviewed
May 23, 2020
mcg-web
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful to change the way the cursor of the edges of a connection are encoded/decoded, e.g. in the tests or if base64 is not the format users want to use for their applications. With this PR the
ConnectionBuildernow accepts a new parameter that allows such customization. I chose to put the parameter as first rather that as the last (sadly breaking BC) because I think that even if rare it's probably more common the willing of changing how the cursor is encoded instead of how the edges or the connection itself are built, but of course this can be re-evaluated.