Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-exports-from-components rule to allow exceptions #395

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

ota-meshi
Copy link
Owner

@ota-meshi ota-meshi commented Jun 11, 2024

Related to #385

Updates the no-exports-from-components rule to include exceptions for getStaticPath and prerender named exports, and enhances documentation and tests accordingly.

  • Modifies the rule implementation in src/rules/no-exports-from-components.ts to allow getStaticPath and prerender as named exports, while still disallowing other value exports.
  • Updates the documentation in docs/rules/no-exports-from-components.md to mention these exceptions and provide examples of allowed and disallowed exports.
  • Adds test case fixtures in tests/fixtures/rules/no-exports-from-components/valid/ to verify the rule correctly allows the exceptions.

For more details, open the Copilot Workspace session.

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: eb15b84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi merged commit 5174590 into main Jun 11, 2024
8 checks passed
@ota-meshi ota-meshi deleted the update-no-exports-rule branch June 11, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant