Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug with floating numbers on exact split calculator #135

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

alexanderwassbjer
Copy link
Contributor

This is a fix of the issue: #113

Now the calc is correct with max 2 decimals and also the save button is toggled correct based on 2 decimals.

Screenshot:
image
image

This was referenced Oct 27, 2024
@alexanderwassbjer alexanderwassbjer changed the title Fix bug with floating numbers on exact split calculator 🐛 Fix bug with floating numbers on exact split calculator Oct 27, 2024
@KMKoushik
Copy link
Member

ready to be reviwed right?

@alexanderwassbjer
Copy link
Contributor Author

ready to be reviwed right?

Yes 😊

@KMKoushik KMKoushik self-requested a review October 27, 2024 19:50
Copy link
Member

@KMKoushik KMKoushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM

@KMKoushik KMKoushik merged commit 9bc538f into oss-apps:main Oct 27, 2024
@alexanderwassbjer
Copy link
Contributor Author

TYSM
np 🥳

@alexanderwassbjer alexanderwassbjer deleted the bugfix/floating-numbers branch October 29, 2024 08:51
KMKoushik added a commit that referenced this pull request Nov 8, 2024
* Add dark and light support

* Add theme selector on account page

* Add theme selector

* 🐛 Fix bug with floating numbers on exact split calculator (#135)

Fix bug with floating numbers on exact split calculator

* Update default theme

* Fix the theme color on light mode

* 🚀 Order by expense created date in the groups list (#139)

Order by expense created date in the groups list

* 🚀 Redirect to groupexpense or expense in activity list based on groupId (#140)

Redirect to groupexpense or expense in activity list based on groupId

* 🚀 Add group created date and first expense date (#141)

* Add group created date and first expense date

* Fixup

* fix date format error

* fix deleted expense included in total stats

---------

Co-authored-by: KMKoushik <koushikmohan1996@gmail.com>
@KMKoushik KMKoushik mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants