Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a collections page #2524

Closed
casey opened this issue Oct 12, 2023 · 4 comments
Closed

Add a collections page #2524

casey opened this issue Oct 12, 2023 · 4 comments
Assignees

Comments

@casey
Copy link
Collaborator

casey commented Oct 12, 2023

I'd like to be able to see in one place all the inscriptions which are using genetic provenance. "collections" might not be the right word, but something like /collections, where all collections are shown, in order of how recently a child was added to the collection.

@veryordinally veryordinally self-assigned this Oct 17, 2023
@lifofifoX
Copy link
Collaborator

Probably a good idea to paginate the children on inscription page too, otherwise it'll try to load all the children on the same page. Maybe, the children list could be capped at 10 along with a link to this new collections page.

@a-edakin
Copy link

a-edakin commented Oct 27, 2023

Probably a good idea to paginate the children on inscription page too, otherwise it'll try to load all the children on the same page. Maybe, the children list could be capped at 10 along with a link to this new collections page.

Yep, and that is exactly a problem I encountered

curl --location --request GET 'http://<testnet>/inscription/4728a9610731cc4ddcc7285d3c52aa535ba73ca4400b34d002bce703612e3c68i0' --header 'Accept: application/json'

http://<testnet>/inscription/4728a9610731cc4ddcc7285d3c52aa535ba73ca4400b34d002bce703612e3c68i0

This collection has over 2000+ children and page takes forever to load just like JSON API

I would suggest to separate children from parent in API response since pagination in the same response would be awkward and make 2 endpoints /inscription/<inscription_id> and /inscription/<inscription_id>/children with pagination

@ordinalOS
Copy link

Good work team. Please consider a "Network Graph" style display here: https://ordinalos.github.io/bussy-tree/

@raphjaph
Copy link
Collaborator

Closed by #2561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

6 participants