Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump go version to v1.22.5 #385

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

perdasilva
Copy link
Contributor

No description provided.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (08ab7fb) to head (63eb47c).
Report is 39 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (63eb47c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (63eb47c)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   85.06%   79.50%   -5.56%     
==========================================
  Files          19       31      +12     
  Lines        1346     1952     +606     
==========================================
+ Hits         1145     1552     +407     
- Misses        125      312     +187     
- Partials       76       88      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva disabled auto-merge August 29, 2024 11:46
@perdasilva perdasilva merged commit 05fd16e into operator-framework:main Aug 29, 2024
6 checks passed
@perdasilva perdasilva deleted the perdasilva/bump/go branch August 29, 2024 11:46
@RTann
Copy link

RTann commented Sep 17, 2024

@perdasilva why was the go directive bumped to 1.22.5? Did an underlying dependency require this change? Otherwise, I do not believe the semantics of the language changed between 1.22.0 and 1.22.5.

I believe if the goal were to ensure people who run this as the main module, then the go directive should have been kept as-is and toolchain go1.22.5 should have been added, instead.

Now, users who use this as a library instead of the main module are forced to bump their go.mod's go directive to go 1.22.5, which is disruptive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants