Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1076 - Fix/enable reopening device view #1077

Merged
merged 4 commits into from
Feb 8, 2020
Merged

#1076 - Fix/enable reopening device view #1077

merged 4 commits into from
Feb 8, 2020
+224 −18

Conversation

lukzeg
Copy link
Contributor

@lukzeg lukzeg commented Jul 18, 2019

#1076

Simply fix for enabling reselecting device from Device Icon List. The device is released only after clicking Stop Using button.

@lukzeg lukzeg mentioned this pull request Sep 11, 2019
Merged
@lukzeg
Copy link
Contributor Author

lukzeg commented Sep 19, 2019

HI @koral-- , @sorccu ,

I added tests for the fix, which prove that it works.

New tests added:

  • should be able to reuse assign device (fix for this issue)
  • should not display used device if filter is set to - state using
  • should be able to unassign used device
  • should be able to reuse assign device
  • should one device be marked as busy as is used by another user
  • should not be able to pick up device marked as busy
  • should display amount of devices used by the user
  • should display user name after login on widget

Please let me know if it suits you, or I should fix something.

@koral-- koral-- merged commit 6742a4d into openstf:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koral-- koral-- koral-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukzeg @koral--