Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: events overhaul #1190

Closed
wants to merge 2 commits into from
Closed

wip: events overhaul #1190

wants to merge 2 commits into from

Conversation

Tal-or
Copy link
Collaborator

@Tal-or Tal-or commented Feb 11, 2025

No description provided.

@Tal-or
optimized-recorder: send event only when loaded
4cd7f23 
An optimized version of the standard recoder that will send an event
only when got loaded by the caller code.

This will use to record an event only when something actually changed.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
wip: how to use optimized recorder
2ddf412 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2025
@Tal-or Tal-or changed the title wip: Events overhaul wip: events overhaul Feb 11, 2025
@openshift-ci openshift-ci bot requested review from ffromani and shajmakh February 11, 2025 17:27
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@Tal-or: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-install-e2e 2ddf412 link true /test ci-install-e2e
ci/prow/ci-e2e 2ddf412 link true /test ci-e2e
ci/prow/ci-e2e-install-hypershift 2ddf412 link true /test ci-e2e-install-hypershift
ci/prow/ci-unit 2ddf412 link true /test ci-unit
ci/prow/ci-index-tested-numaresources-operator-bundle 2ddf412 link true /test ci-index-tested-numaresources-operator-bundle
ci/prow/images 2ddf412 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Tal-or
Copy link
Collaborator Author

Tal-or commented Feb 18, 2025

superseded by: #1194

@Tal-or Tal-or closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani Awaiting requested review from ffromani

@shajmakh shajmakh Awaiting requested review from shajmakh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tal-or