-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported OpenAPI spec reference to JSON Schema #735
Remove unsupported OpenAPI spec reference to JSON Schema #735
Conversation
As per the conversation on the bi-weekly call today, the |
@Samze after reading the OpenAPI specification I figured we could change the value of the enum to a string and that would be enough to satisfy the generator, I pushed the change to this branch and now the values are the same as before and correctly interpreted by the generator. I'm looking into the CLA issue today. |
@Samze I believe the CLA is authorized but I can't load the EasyCLA page to confirm that, are you able to verify and maybe re-run the validation? |
cb29764
to
43f0304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I'm not an approver on the project
What is the problem this PR solves?
Remove the JSON Schema reference from the field and turn it into an object like the swagger file.
Adds required tags and an
_
to one of the states since spaces are not supported by OpenAPI when the field is an enum so the spec passes validation from tools like gnostic or openapi-generator.Checklist:
Fixes #734
After applying this changes openapi can generate bindings for any language without any issue: