-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maintenance info to the response of fetching a service instance #722
Merged
fmui
merged 2 commits into
openservicebrokerapi:master
from
orange-cloudfoundry:mi-refresh
Oct 27, 2020
Merged
Add maintenance info to the response of fetching a service instance #722
fmui
merged 2 commits into
openservicebrokerapi:master
from
orange-cloudfoundry:mi-refresh
Oct 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provides rationale for platform to poll the "fetching a service instance" endpoint
rsampaio
previously approved these changes
Aug 18, 2020
alexwo
reviewed
Aug 30, 2020
alexwo
previously approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fmui
previously approved these changes
Sep 15, 2020
Samze
approved these changes
Sep 15, 2020
Samze
reviewed
Sep 15, 2020
Samze
requested changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to capitalise SHOULD
As suggested by @Samze in openservicebrokerapi#722 (review)
gberche-orange
dismissed stale reviews from fmui, alexwo, and rsampaio
via
September 15, 2020 15:10
da16ac1
Samze
approved these changes
Sep 15, 2020
fmui
approved these changes
Oct 27, 2020
rsampaio
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provides rationale for platform to poll the "fetching a service instance" endpoint
What is the problem this PR solves?
closes #714
Checklist: