Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix carat height #106

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix carat height #106

merged 1 commit into from
Nov 8, 2022

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Nov 3, 2022 •
edited
Loading

Description

Fix the height of the carat for the version selector

2022-11-03 13_45_36-Card - OpenSearch UI Framework

Issues Resolved

#105

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BSFishy
Fix carat height
5d3ec7f 
Signed-off-by: Matt Provost <provomat@amazon.com>
@BSFishy BSFishy requested a review from a team as a code owner November 3, 2022 20:08
KrooshalUX
KrooshalUX approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bandinib-amzn bandinib-amzn merged commit d807a94 into opensearch-project:main Nov 8, 2022
@BSFishy BSFishy self-assigned this Dec 16, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 5, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 5, 2023
@BSFishy @github-actions
Fix carat height (#106)
bd7c469 
Signed-off-by: Matt Provost <provomat@amazon.com>

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit d807a94)
BSFishy added a commit that referenced this pull request Jan 6, 2023
@opensearch-trigger-bot @BSFishy
Fix carat height (#106) (#191)
4c55fa5 
Signed-off-by: Matt Provost <provomat@amazon.com>

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit d807a94)

Co-authored-by: Matt Provost <mattprovost6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaddy645 kaddy645 kaddy645 approved these changes

@bandinib-amzn bandinib-amzn bandinib-amzn approved these changes

@KrooshalUX KrooshalUX KrooshalUX approved these changes

Assignees

@BSFishy BSFishy

Labels
backport 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BSFishy @kaddy645 @bandinib-amzn @KrooshalUX