Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Update ouiTextSubduedColor in next dark theme #1025

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 309e146 from #973.

* Update ouiTextSubduedColor in `next` dark theme

Shade the theme's `$ouiTextColor` instead of using one of the grayscale shades

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* update changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 309e146)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@joshuarrrr
Copy link
Member

ah, bummer I missed this 😞 . Thanks for catching! Are you auditing other PRs we didn't backport as intended?

@BSFishy
Copy link
Contributor

BSFishy commented Sep 7, 2023

ah, bummer I missed this 😞 . Thanks for catching! Are you auditing other PRs we didn't backport as intended?

I just went through the changelog, compared that with the diff between 1.2 and 1.3 and moved over the ones that were in 1.3. This one didn't make it in (the only one in fact), so I checked it to see if it didn't have a backport and sure enough

@BSFishy BSFishy merged commit d050ff9 into 1.x Sep 8, 2023
@github-actions github-actions bot deleted the backport/backport-973-to-1.x branch September 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants