Use AbstractBatchingProcessor for InferenceProcessor #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chishui
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun and
zhichao-aws
as code owners
|
@chishui Please take a look on the conflict. |
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
chishui
force-pushed
the
batch-processor-main
branch
from
93a28b2 to
7537831
Compare
conflicts have been resolved |
zane-neo
approved these changes
Jul 10, 2024
Merged
3 tasks
zhichao-aws
approved these changes
Jul 12, 2024
zhichao-aws
added
the
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Use AbstractBatchingProcessor for InferenceProcessor Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Add chagnelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> --------- Signed-off-by: Liyun Xiu <xiliyun@amazon.com> (cherry picked from commit bf2fd5a)
zhichao-aws
added a commit
that referenced
this pull request
Jul 19, 2024
* Use AbstractBatchingProcessor for InferenceProcessor Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Add chagnelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> --------- Signed-off-by: Liyun Xiu <xiliyun@amazon.com> (cherry picked from commit bf2fd5a) Co-authored-by: Liyun Xiu <xiliyun@amazon.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com>
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on discussion, it's strongly recommended to move sub batching logic from
_bulkAPI to each processor.So for two batch supporting processors: text_embedding, sparse_encoding, based on discussion, we make them inherit from a newly introduced
AbstractBatchingProcessingso that these two processors supports a new optional parameterbatch_sizeand this parameter can control the cutting sub batches logic. The default of this parameter is 1 to be consistent with existing behavior.Add more integration tests.
Issues Resolved
opensearch-project/OpenSearch#14283
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.