Add github action to publish snapshots to maven #711

ankitkala · 2023-02-21T05:00:37Z

Description

Add github action to publish snapshots to maven

Issues Resolved

Testing Done

Tested by publishing to the local filesystem

cross-cluster-replication ankikala$ tree snapshots/
snapshots/
└── org
    └── opensearch
        └── plugin
            └── opensearch-cross-cluster-replication
                ├── 3.0.0.0-SNAPSHOT
                │   ├── maven-metadata.xml
                │   ├── maven-metadata.xml.md5
                │   ├── maven-metadata.xml.sha1
                │   ├── maven-metadata.xml.sha256
                │   ├── maven-metadata.xml.sha512
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.pom
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.pom.md5
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.pom.sha1
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.pom.sha256
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.pom.sha512
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.zip
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.zip.md5
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.zip.sha1
                │   ├── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.zip.sha256
                │   └── opensearch-cross-cluster-replication-3.0.0.0-20230221.070242-1.zip.sha512
                ├── maven-metadata.xml
                ├── maven-metadata.xml.md5
                ├── maven-metadata.xml.sha1
                ├── maven-metadata.xml.sha256
                └── maven-metadata.xml.sha512

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

codecov-commenter · 2023-02-21T05:24:42Z

Codecov Report

Merging #711 (0bb4576) into main (cafc069) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

❗ Current head 0bb4576 differs from pull request most recent head 1f88409. Consider uploading reports for the commit 1f88409 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #711      +/-   ##
============================================
- Coverage     73.34%   73.25%   -0.09%     
  Complexity      997      997              
============================================
  Files           141      141              
  Lines          4637     4637              
  Branches        519      519              
============================================
- Hits           3401     3397       -4     
- Misses          911      916       +5     
+ Partials        325      324       -1

Impacted Files	Coverage Δ
...h/replication/task/index/IndexReplicationParams.kt	`77.77% <0.00%> (ø)`
...h/replication/task/shard/ShardReplicationParams.kt	`62.22% <100.00%> (ø)`
...rch/replication/task/index/IndexReplicationTask.kt	`67.86% <0.00%> (-0.85%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ankitkala · 2023-02-21T06:54:02Z

BWC and security test failures are known issues on main

gaiksaya · 2023-02-21T17:54:20Z

.github/workflows/maven-publish.yml

+      fail-fast: false
+      matrix:
+        jdk: [11, 17]
+        platform: ["ubuntu-latest", "windows-latest", "macos-latest"]


I dont think you need to build on all platforms to publish to maven. Same with JDK.

Ack. Updated.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

gaiksaya · 2023-02-22T03:20:24Z

.github/workflows/maven-publish.yml

+    ]
+
+jobs:
+  build-and-publish-snapshots:\


gaiksaya

I added the required secret role: PUBLISH_SNAPSHOTS_ROLE
Please fix the typo and it should be good to merge.
Thanks!

Signed-off-by: Ankit Kala <ankikala@amazon.com>

ankitkala · 2023-02-22T09:50:49Z

Build started failing due to a breaking change in OS: /~https://github.com/opensearch-project/cross-cluster-replication/pull/718/files

WIll raise a backport PR manually in 2.x for now.

ankitkala requested a review from a team February 21, 2023 05:00

ankitkala assigned gaiksaya Feb 21, 2023

Add github action to publish snapshots to maven

1f88409

Signed-off-by: Ankit Kala <ankikala@amazon.com>

monusingh-1 previously approved these changes Feb 21, 2023

View reviewed changes

sricharanvuppu previously approved these changes Feb 21, 2023

View reviewed changes

gaiksaya reviewed Feb 21, 2023

View reviewed changes

ankitkala dismissed stale reviews from sricharanvuppu and monusingh-1 via ce45cb9 February 22, 2023 03:10

Addressing comments

455f8dc

Signed-off-by: Ankit Kala <ankikala@amazon.com>

gaiksaya reviewed Feb 22, 2023

View reviewed changes

.github/workflows/maven-publish.yml Outdated

]

jobs:

build-and-publish-snapshots:\

Copy link

Member

gaiksaya Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: \

gaiksaya previously approved these changes Feb 22, 2023

View reviewed changes

Typo fix

f1d334e

Signed-off-by: Ankit Kala <ankikala@amazon.com>

ankitkala dismissed gaiksaya’s stale review via f1d334e February 22, 2023 03:52

gaiksaya approved these changes Feb 22, 2023

View reviewed changes

ankitkala added backport 2.x backport 2.6 labels Feb 22, 2023

ankitkala mentioned this pull request Feb 22, 2023

[Backport]Add github action to publish snapshots to maven #719

Merged

5 tasks

ankitkala removed backport 2.x backport 2.6 labels Feb 22, 2023

ankitkala enabled auto-merge (squash) February 28, 2023 12:24

ankitkala closed this Apr 5, 2023

auto-merge was automatically disabled April 5, 2023 11:45
Pull request was closed

ankitkala deleted the maven-release branch April 5, 2023 11:45

This was referenced Feb 28, 2025

[BUG] ccr plugin snapshots are not published to maven repo #1508

Open

Adding github action in ccr to publish snapshots to maven #1509

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add github action to publish snapshots to maven #711

Add github action to publish snapshots to maven #711

ankitkala commented Feb 21, 2023 •

edited

Loading

codecov-commenter commented Feb 21, 2023 •

edited

Loading

ankitkala commented Feb 21, 2023

gaiksaya Feb 21, 2023 •

edited

Loading

ankitkala Feb 22, 2023

gaiksaya Feb 22, 2023

gaiksaya left a comment

ankitkala commented Feb 22, 2023

Add github action to publish snapshots to maven #711

Add github action to publish snapshots to maven #711

Conversation

ankitkala commented Feb 21, 2023 • edited Loading

Description

Issues Resolved

Testing Done

Check List

codecov-commenter commented Feb 21, 2023 • edited Loading

Codecov Report

ankitkala commented Feb 21, 2023

gaiksaya Feb 21, 2023 • edited Loading

Choose a reason for hiding this comment

ankitkala Feb 22, 2023

Choose a reason for hiding this comment

gaiksaya Feb 22, 2023

Choose a reason for hiding this comment

gaiksaya left a comment

Choose a reason for hiding this comment

ankitkala commented Feb 22, 2023

ankitkala commented Feb 21, 2023 •

edited

Loading

codecov-commenter commented Feb 21, 2023 •

edited

Loading

gaiksaya Feb 21, 2023 •

edited

Loading