Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump axios from 0.28.1 to 0.29.0 in 2.x #9411

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 18, 2025

Description

Bump axios from 0.28.1 to 0.29.0 in 2.x

yarn why axios
yarn why v1.22.21
[1/4] 🤔  Why do we have the module "axios"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "typescript@4.0.2" is incompatible with requested version "typescript@~4.5.2"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "axios@0.29.0"
info Has been hoisted to "axios"
info Reasons this module exists
   - "workspace-aggregator-712dbdc8-f238-4c64-9eb7-5bb044cdcd99" depends on it
   - Hoisted from "_project_#@osd#ui-shared-deps#axios"
   - Hoisted from "_project_#@osd#dev-utils#axios"
info Disk size without dependencies: "1.14MB"
info Disk size with unique dependencies: "1.3MB"
info Disk size with transitive dependencies: "1.68MB"
info Number of shared dependencies: 7
=> Found "chromedriver#axios@1.7.9"
info This module exists because "_project_#chromedriver" depends on it.
info Disk size without dependencies: "2.33MB"
info Disk size with unique dependencies: "2.49MB"
info Disk size with transitive dependencies: "2.87MB"
info Number of shared dependencies: 7
✨  Done in 1.20s.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Anan <ananzh@amazon.com>
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 18, 2025
@ananzh ananzh added cve Security vulnerabilities detected by Dependabot or Mend v2.20.0 labels Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.81%. Comparing base (027837b) to head (f96a180).
Report is 10 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #9411      +/-   ##
==========================================
- Coverage   61.81%   61.81%   -0.01%     
==========================================
  Files        3816     3816              
  Lines       91865    91865              
  Branches    14545    14545              
==========================================
- Hits        56788    56786       -2     
- Misses      31426    31427       +1     
- Partials     3651     3652       +1     
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.60% <ø> (ø)
Linux_3 39.23% <ø> (-0.01%) ⬇️
Linux_4 29.01% <ø> (ø)
Windows_1 29.02% <ø> (ø)
Windows_2 56.55% <ø> (ø)
Windows_3 39.23% <ø> (ø)
Windows_4 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sulabhjain-dev
Copy link

Thanks @ananzh for this PR. Looks good.

@ananzh ananzh added v2.19.1 Issues targeting release v2.19.1 backport 2.x labels Feb 26, 2025
@ananzh ananzh merged commit 3e755e7 into opensearch-project:2.x Feb 26, 2025
72 of 75 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9411-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3e755e77896c9c27ac0612035f27176b5c09f021
# Push it to GitHub
git push --set-upstream origin backport/backport-9411-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9411-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 26, 2025
Signed-off-by: Anan <ananzh@amazon.com>
(cherry picked from commit 3e755e7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
angle943 pushed a commit that referenced this pull request Feb 26, 2025
(cherry picked from commit 3e755e7)

Signed-off-by: Anan <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.19 cve Security vulnerabilities detected by Dependabot or Mend failed backport Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.19.1 Issues targeting release v2.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants