style: Update sidecar style to align with new page header #9269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9269 +/- ##
=======================================
Coverage 61.68% 61.68%
=======================================
Files 3816 3816
Lines 91693 91693
Branches 14516 14516
=======================================
+ Hits 56557 56559 +2
+ Misses 31510 31509 -1
+ Partials 3626 3625 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jan 24, 2025
wanglam
approved these changes
Jan 24, 2025
Hailong-am
approved these changes
Jan 24, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* style: update sidecar style to align with new page header Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #9269 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2f61e47) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Jan 24, 2025
) * style: update sidecar style to align with new page header * Changeset file for PR #9269 created/updated --------- (cherry picked from commit 2f61e47) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruchidh
pushed a commit
to ruchidh/OpenSearch-Dashboards
that referenced
this pull request
Jan 30, 2025
…-project#9269) * style: update sidecar style to align with new page header Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#9269 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Ubuntu <ubuntu@ip-172-31-47-220.us-west-2.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update sidecar style to align with new page header
Screenshot
Old page header is still working well.
Before
After
Before
After
Testing the changes
Install assistant and switch dock mode to verify.
Changelog
Check List
yarn test:jestyarn test:jest_integration