[workspace]fix the bug that mistakenly classify data connection #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
…search-project#8999) * add 2 step loading Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR opensearch-project#8999 created/updated * ifx ut Signed-off-by: Qxisylolo <qianxisy@amazon.com> * resolve comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete functions Signed-off-by: Qxisylolo <qianxisy@amazon.com> * separately fetch dqc Signed-off-by: Qxisylolo <qianxisy@amazon.com> * small mistakes Signed-off-by: Qxisylolo <qianxisy@amazon.com> * dqc should not show data source without dqc Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * new update Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete non-used import Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete if Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add try catch Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Qxisylolo
force-pushed
the
fix/bug_in_data_connection
branch
2 times, most recently
from
4c98d36 to
64c3c10
Compare
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
Qxisylolo
requested review from
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Qxisylolo
force-pushed
the
fix/bug_in_data_connection
branch
from
64c3c10 to
544af30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9237 +/- ##
=======================================
Coverage 61.67% 61.68%
=======================================
Files 3817 3817
Lines 91719 91695 -24
Branches 14517 14516 -1
=======================================
- Hits 56565 56558 -7
+ Misses 31524 31511 -13
+ Partials 3630 3626 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can we add add unit test to cover the newly added param: mode? |
Already added, please have a review, thank you~ |
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
SuZhou-Joe
approved these changes
Jan 22, 2025
ruanyl
approved these changes
Jan 22, 2025
|
ciGroup 10 / 11 are known issue. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* fix the bug that mistakely miscategorify data connection Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #9237 created/updated * [workspace]add 2 step loading in 'Associate data sources' modal (#8999) * add 2 step loading Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #8999 created/updated * ifx ut Signed-off-by: Qxisylolo <qianxisy@amazon.com> * resolve comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete functions Signed-off-by: Qxisylolo <qianxisy@amazon.com> * separately fetch dqc Signed-off-by: Qxisylolo <qianxisy@amazon.com> * small mistakes Signed-off-by: Qxisylolo <qianxisy@amazon.com> * dqc should not show data source without dqc Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * new update Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete non-used import Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete if Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add try catch Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> * fix the bug that mistakely miscategorify data connection Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix conflict Signed-off-by: Qxisylolo <qianxisy@amazon.com> * conflicts Signed-off-by: Qxisylolo <qianxisy@amazon.com> * small fix Signed-off-by: Qxisylolo <qianxisy@amazon.com> * typo Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete one Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 11918b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jan 24, 2025
… (#9256) * fix the bug that mistakely miscategorify data connection * Changeset file for PR #9237 created/updated * [workspace]add 2 step loading in 'Associate data sources' modal (#8999) * add 2 step loading * Changeset file for PR #8999 created/updated * ifx ut * resolve comments * delete functions * separately fetch dqc * small mistakes * dqc should not show data source without dqc * fix tests * new update * delete non-used import * delete if * add try catch --------- * fix the bug that mistakely miscategorify data connection * fix conflict * conflicts * small fix * typo * add tests * delete one --------- (cherry picked from commit 11918b6) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
ruchidh
pushed a commit
to ruchidh/OpenSearch-Dashboards
that referenced
this pull request
Jan 30, 2025
…search-project#9237) * fix the bug that mistakely miscategorify data connection Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR opensearch-project#9237 created/updated * [workspace]add 2 step loading in 'Associate data sources' modal (opensearch-project#8999) * add 2 step loading Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR opensearch-project#8999 created/updated * ifx ut Signed-off-by: Qxisylolo <qianxisy@amazon.com> * resolve comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete functions Signed-off-by: Qxisylolo <qianxisy@amazon.com> * separately fetch dqc Signed-off-by: Qxisylolo <qianxisy@amazon.com> * small mistakes Signed-off-by: Qxisylolo <qianxisy@amazon.com> * dqc should not show data source without dqc Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * new update Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete non-used import Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete if Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add try catch Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> * fix the bug that mistakely miscategorify data connection Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix conflict Signed-off-by: Qxisylolo <qianxisy@amazon.com> * conflicts Signed-off-by: Qxisylolo <qianxisy@amazon.com> * small fix Signed-off-by: Qxisylolo <qianxisy@amazon.com> * typo Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * delete one Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Ubuntu <ubuntu@ip-172-31-47-220.us-west-2.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the bug of incorrect classification for data connections and optimizes operations by removing the fetching DQC when user associates an OpenSearch data source(only one step)
Issues Resolved
Screenshot
2025-01-22.11.25.46.mov
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration