Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Support to dissociate data connection object since DSM list has supported to display #9164

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

raintygao
Copy link
Contributor

Description

Support to dissociate data connection object since DSM list has supported to display

Screenshot

image
There is no UI changes in this PR, after this PR users could dissociate DQS in workspace DSM list direct query connections tab.

Testing the changes

Go to data source management list page in workspace, then you could associate and dissociate DQS object.
This change has been tested in local and related unit tests have been added.

Changelog

  • feat: Support to dissociate data connection object since DSM list has supported to display

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (c382d1a) to head (b5695c8).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ion/manage_direct_query_data_connections_table.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9164      +/-   ##
==========================================
+ Coverage   60.97%   61.00%   +0.03%     
==========================================
  Files        3812     3812              
  Lines       91358    91386      +28     
  Branches    14435    14438       +3     
==========================================
+ Hits        55703    55754      +51     
+ Misses      32099    32072      -27     
- Partials     3556     3560       +4     
Flag Coverage Δ
Linux_1 29.07% <ø> (+0.02%) ⬆️
Linux_2 56.45% <ø> (ø)
Linux_3 37.99% <50.00%> (+0.02%) ⬆️
Linux_4 29.03% <ø> (ø)
Windows_1 29.10% <ø> (+0.03%) ⬆️
Windows_2 56.40% <ø> (ø)
Windows_3 38.00% <50.00%> (?)
Windows_4 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit 82689bb into opensearch-project:main Jan 9, 2025
72 of 73 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9164-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82689bbbccc586b198f3ea74cb03dce8e6c39738
# Push it to GitHub
git push --set-upstream origin backport/backport-9164-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9164-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9164-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82689bbbccc586b198f3ea74cb03dce8e6c39738
# Push it to GitHub
git push --set-upstream origin backport/backport-9164-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9164-to-2.x.

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Jan 10, 2025
…st has supported to display (opensearch-project#9164)

* support data connection object in DSM list to disassociate

Signed-off-by: tygao <tygao@amazon.com>

* test: add unit tests

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#9164 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 15, 2025
…st has supported to display (#9164)

* support data connection object in DSM list to disassociate

Signed-off-by: tygao <tygao@amazon.com>

* test: add unit tests

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #9164 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 82689bb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jan 16, 2025
…st has supported to display (#9164) (#9188)

* support data connection object in DSM list to disassociate



* test: add unit tests



* Changeset file for PR #9164 created/updated

---------



(cherry picked from commit 82689bb)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
d-buckner pushed a commit to d-buckner/OpenSearch-Dashboards that referenced this pull request Jan 17, 2025
…st has supported to display (opensearch-project#9164)

* support data connection object in DSM list to disassociate

Signed-off-by: tygao <tygao@amazon.com>

* test: add unit tests

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#9164 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants