-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Support to dissociate data connection object since DSM list has supported to display #9164
Conversation
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9164 +/- ##
==========================================
+ Coverage 60.97% 61.00% +0.03%
==========================================
Files 3812 3812
Lines 91358 91386 +28
Branches 14435 14438 +3
==========================================
+ Hits 55703 55754 +51
+ Misses 32099 32072 -27
- Partials 3556 3560 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9164-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82689bbbccc586b198f3ea74cb03dce8e6c39738
# Push it to GitHub
git push --set-upstream origin backport/backport-9164-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9164-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82689bbbccc586b198f3ea74cb03dce8e6c39738
# Push it to GitHub
git push --set-upstream origin backport/backport-9164-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…st has supported to display (opensearch-project#9164) * support data connection object in DSM list to disassociate Signed-off-by: tygao <tygao@amazon.com> * test: add unit tests Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#9164 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…st has supported to display (#9164) * support data connection object in DSM list to disassociate Signed-off-by: tygao <tygao@amazon.com> * test: add unit tests Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #9164 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 82689bb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…st has supported to display (#9164) (#9188) * support data connection object in DSM list to disassociate * test: add unit tests * Changeset file for PR #9164 created/updated --------- (cherry picked from commit 82689bb) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…st has supported to display (opensearch-project#9164) * support data connection object in DSM list to disassociate Signed-off-by: tygao <tygao@amazon.com> * test: add unit tests Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#9164 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Support to dissociate data connection object since DSM list has supported to display
Screenshot
There is no UI changes in this PR, after this PR users could dissociate DQS in workspace DSM list direct query connections tab.
Testing the changes
Go to data source management list page in workspace, then you could associate and dissociate DQS object.
This change has been tested in local and related unit tests have been added.
Changelog
Check List
yarn test:jest
yarn test:jest_integration