[Workspace] fix: hide collaborators page on nav when newHomePage is disabled #9116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
SuZhou-Joe
approved these changes
Dec 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9116 +/- ##
==========================================
- Coverage 60.90% 60.90% -0.01%
==========================================
Files 3808 3808
Lines 91178 91180 +2
Branches 14396 14397 +1
==========================================
Hits 55531 55531
- Misses 32094 32096 +2
Partials 3553 3553
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Dec 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
…isabled (#9116) * fix: fix collaborators page on nav when newHomePage is disabled Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #9116 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b603c21) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
silvaf-dev
pushed a commit
to silvaf-dev/OpenSearch-Dashboards
that referenced
this pull request
Dec 26, 2024
…isabled (opensearch-project#9116) * fix: fix collaborators page on nav when newHomePage is disabled Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#9116 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Federico Silva <federico.silva.dev@gmail.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Dec 27, 2024
…isabled (#9116) (#9117) * fix: fix collaborators page on nav when newHomePage is disabled * Changeset file for PR #9116 created/updated --------- (cherry picked from commit b603c21) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide collaborators page on nav when newHomePage is disabled
Screenshot
Before
After
Testing the changes
Disable new home page, then go to home page navigation, the collaborator nav link will be hidden.
Changelog
Check List
yarn test:jestyarn test:jest_integration