[Workspace] add missing method for workspace client interface #9070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9070 +/- ##
==========================================
- Coverage 60.90% 60.90% -0.01%
==========================================
Files 3808 3808
Lines 91180 91180
Branches 14397 14397
==========================================
- Hits 55531 55529 -2
- Misses 32096 32097 +1
- Partials 3553 3554 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…rch-Dashboards into 2.19/add-missing-method
Hailong-am
reviewed
Dec 19, 2024
There was a problem hiding this comment.
we may not need to expose create, delete, update in core, they may treated as workspace internal methods. what do you think @ruanyl @SuZhou-Joe
There was a problem hiding this comment.
From my perspective, it is OK to expose those methods though for now there is not a use case.
SuZhou-Joe
previously approved these changes
Dec 24, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
approved these changes
Dec 24, 2024
SuZhou-Joe
approved these changes
Dec 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 25, 2024
* add missing method for workspace client interface Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #9070 created/updated * fix bootstrap issue Signed-off-by: yubonluo <yubonluo@amazon.com> * fix error Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c836e60) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Dec 27, 2024
…#9123) * add missing method for workspace client interface * Changeset file for PR #9070 created/updated * fix bootstrap issue * fix error --------- (cherry picked from commit c836e60) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add missing method for workspace client interface
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration