-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Isolate objects based on workspace when calling get/bulkGet #8888
Merged
Hailong-am
merged 9 commits into
opensearch-project:main
from
yubonluo:2.19/validate-obj-call-get
Dec 2, 2024
Merged
[Workspace] Isolate objects based on workspace when calling get/bulkGet #8888
Hailong-am
merged 9 commits into
opensearch-project:main
from
yubonluo:2.19/validate-obj-call-get
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8888 +/- ##
==========================================
+ Coverage 60.85% 60.89% +0.03%
==========================================
Files 3802 3802
Lines 91059 91083 +24
Branches 14376 14383 +7
==========================================
+ Hits 55417 55467 +50
+ Misses 32103 32074 -29
- Partials 3539 3542 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
reviewed
Nov 20, 2024
...ugins/workspace/server/saved_objects/integration_tests/workspace_id_consumer_wrapper.test.ts
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Nov 20, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
kavilla
previously approved these changes
Nov 20, 2024
kavilla
reviewed
Nov 20, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
kavilla
reviewed
Nov 20, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
previously approved these changes
Nov 28, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
wanglam
reviewed
Nov 29, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Show resolved
Hide resolved
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Nov 29, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Show resolved
Hide resolved
SuZhou-Joe
previously approved these changes
Nov 29, 2024
Hailong-am
reviewed
Dec 2, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
Hailong-am
previously approved these changes
Dec 2, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
approved these changes
Dec 2, 2024
Hailong-am
approved these changes
Dec 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
…et (#8888) * Isolate objects based on workspace when calling get/bulkGet Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #8888 created/updated * add integration tests Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the function name Signed-off-by: yubonluo <yubonluo@amazon.com> * add data source validate Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b31206a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Dec 3, 2024
…et (#8888) (#8990) * Isolate objects based on workspace when calling get/bulkGet * Changeset file for PR #8888 created/updated * add integration tests * optimize the code * optimize the code * optimize the code * optimize the function name * add data source validate * optimize the code --------- (cherry picked from commit b31206a) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ArgusLi
pushed a commit
to ArgusLi/OpenSearch-Dashboards
that referenced
this pull request
Dec 11, 2024
…et (opensearch-project#8888) * Isolate objects based on workspace when calling get/bulkGet Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#8888 created/updated * add integration tests Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the function name Signed-off-by: yubonluo <yubonluo@amazon.com> * add data source validate Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Isolate objects based on workspace when calling get/bulkGet
option.worksapces.length
> 1: Throw error;Issues Resolved
Screenshot
No UI change
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration