[MDS] Fix showing DQS sources list in workspaces #8838

jowg-amazon · 2024-11-09T22:13:07Z

Description

Fixes showing the list of dqs sources in workspaces

Issues Resolved

Screenshot

Testing the changes

Changelog

fix: [MDS] Fix showing DQS sources list in workspaces

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: jowg-amazon <jowg@amazon.com>

github-actions · 2024-11-09T22:13:40Z

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8838.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Signed-off-by: jowg-amazon <jowg@amazon.com>

codecov · 2024-11-09T22:36:46Z

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (c61c7cd) to head (58f2fad).

Files with missing lines	Patch %	Lines
...ion/manage_direct_query_data_connections_table.tsx	77.27%	2 Missing and 3 partials ⚠️
.../data_source_management/public/components/utils.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8838   +/-   ##
=======================================
  Coverage   60.85%   60.86%           
=======================================
  Files        3808     3808           
  Lines       91159    91175   +16     
  Branches    14393    14396    +3     
=======================================
+ Hits        55478    55493   +15     
- Misses      32139    32141    +2     
+ Partials     3542     3541    -1

Flag	Coverage Δ
Linux_1	`28.99% <0.00%> (-0.01%)`	⬇️
Linux_2	`56.38% <ø> (ø)`
Linux_3	`?`
Linux_4	`29.01% <0.00%> (-0.01%)`	⬇️
Windows_1	`29.00% <0.00%> (-0.01%)`	⬇️
Windows_2	`56.34% <ø> (ø)`
Windows_3	`37.95% <75.00%> (+0.01%)`	⬆️
Windows_4	`29.01% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx

Signed-off-by: Joanne Wang <jowg@amazon.com>

AMoo-Miki · 2024-12-18T19:52:52Z

...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx

+                type:
+                  {
+                    S3GLUE: DatasourceTypeToDisplayName.S3GLUE,
+                    PROMETHEUS: DatasourceTypeToDisplayName.PROMETHEUS,
+                  }[dataConnection.connector] || dataConnection.connector,


While I understand this part of the code is barely being changed in this PR, pushing for higher maintainability standards would be to ask for these to be moved to a proper definition of their own as known connectors. This is especially important because this object is used in multiple places.

amsiglan · 2024-12-18T20:06:02Z

...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx

+        setData([...openSearchConnections, ...directQueryConnections]);
+      } catch (error) {
+        // eslint-disable-next-line no-console
+        console.log('Error fetching OpenSearch and Direct Query Connections', error);


Nit: Should we remove this? The user won't benefit from this. Do we want to show the notification toast instead?

added notification toast

amsiglan · 2024-12-18T20:15:55Z

...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx

+        ) {
+          // TODO: link to details page for security lake and cloudwatch
+          return <span style={indentStyle}> {name}</span>;
+        } else {


Nit: Don't need else here since we only return

removed the else

src/plugins/data_source_management/public/components/utils.ts

amsiglan · 2024-12-18T20:23:30Z

Approving with minor comments

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Fix showing DQS sources list in workspaces Signed-off-by: jowg-amazon <jowg@amazon.com> * add changelog Signed-off-by: jowg-amazon <jowg@amazon.com> * Changeset file for PR #8838 created/updated * respond to comments Signed-off-by: Joanne Wang <jowg@amazon.com> * change to use DatasourceTypeToDisplayName Signed-off-by: Joanne Wang <jowg@amazon.com> * update tests Signed-off-by: Joanne Wang <jowg@amazon.com> * respond to comments Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: jowg-amazon <jowg@amazon.com> Signed-off-by: Joanne Wang <jowg@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f85cd6d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix showing DQS sources list in workspaces * add changelog * Changeset file for PR #8838 created/updated * respond to comments * change to use DatasourceTypeToDisplayName * update tests * respond to comments --------- (cherry picked from commit f85cd6d) Signed-off-by: jowg-amazon <jowg@amazon.com> Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Fix showing DQS sources list in workspaces

c8ebd08

Signed-off-by: jowg-amazon <jowg@amazon.com>

github-actions bot added the first-time-contributor label Nov 9, 2024

github-actions bot added the failed changeset label Nov 9, 2024

add changelog

8723d99

Signed-off-by: jowg-amazon <jowg@amazon.com>

raintygao reviewed Nov 20, 2024

View reviewed changes

...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx Outdated Show resolved Hide resolved

jowg-amazon added 8 commits November 22, 2024 17:12

Merge branch 'main' into list_queries

ccd2402

Merge branch 'main' into list_queries

38bbee8

respond to comments

2a784e5

Signed-off-by: Joanne Wang <jowg@amazon.com>

change to use DatasourceTypeToDisplayName

3da83d1

Signed-off-by: Joanne Wang <jowg@amazon.com>

Merge branch 'main' into list_queries

e59c49b

Merge branch 'main' into list_queries

1c810b1

update tests

b30e6cc

Signed-off-by: Joanne Wang <jowg@amazon.com>

Merge branch 'main' into list_queries

14d2404

AMoo-Miki reviewed Dec 18, 2024

View reviewed changes

AMoo-Miki previously approved these changes Dec 18, 2024

View reviewed changes

amsiglan reviewed Dec 18, 2024

View reviewed changes

src/plugins/data_source_management/public/components/utils.ts Outdated Show resolved Hide resolved

amsiglan previously approved these changes Dec 18, 2024

View reviewed changes

jowg-amazon added 2 commits December 19, 2024 12:24

Merge branch 'main' into list_queries

ad91b67

respond to comments

58f2fad

Signed-off-by: Joanne Wang <jowg@amazon.com>

jowg-amazon dismissed stale reviews from AMoo-Miki and amsiglan via 58f2fad December 19, 2024 17:30

Merge branch 'main' into list_queries

adee610

amsiglan approved these changes Dec 19, 2024

View reviewed changes

AMoo-Miki approved these changes Dec 19, 2024

View reviewed changes

AMoo-Miki added backport 2.x v2.19.0 labels Dec 19, 2024

AMoo-Miki merged commit f85cd6d into opensearch-project:main Dec 19, 2024
70 of 71 checks passed

opensearch-trigger-bot bot mentioned this pull request Dec 19, 2024

[Backport 2.x] [MDS] Fix showing DQS sources list in workspaces #9081

Merged

SuZhou-Joe added the workspace label Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MDS] Fix showing DQS sources list in workspaces #8838

[MDS] Fix showing DQS sources list in workspaces #8838

jowg-amazon commented Nov 9, 2024 •

edited

Loading

github-actions bot commented Nov 9, 2024

codecov bot commented Nov 9, 2024 •

edited

Loading

AMoo-Miki Dec 18, 2024

amsiglan Dec 18, 2024 •

edited

Loading

jowg-amazon Dec 19, 2024

amsiglan Dec 18, 2024

jowg-amazon Dec 19, 2024

amsiglan commented Dec 18, 2024

[MDS] Fix showing DQS sources list in workspaces #8838

[MDS] Fix showing DQS sources list in workspaces #8838

Conversation

jowg-amazon commented Nov 9, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Nov 9, 2024

ℹ️ Manual Changeset Creation Reminder

codecov bot commented Nov 9, 2024 • edited Loading

Codecov Report

AMoo-Miki Dec 18, 2024

Choose a reason for hiding this comment

amsiglan Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

jowg-amazon Dec 19, 2024

Choose a reason for hiding this comment

amsiglan Dec 18, 2024

Choose a reason for hiding this comment

jowg-amazon Dec 19, 2024

Choose a reason for hiding this comment

amsiglan commented Dec 18, 2024

jowg-amazon commented Nov 9, 2024 •

edited

Loading

codecov bot commented Nov 9, 2024 •

edited

Loading

amsiglan Dec 18, 2024 •

edited

Loading