-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to using the official release of vega-interpreter
#8744
Conversation
Signed-off-by: Miki <miki@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8744 +/- ##
==========================================
+ Coverage 60.75% 60.76% +0.01%
==========================================
Files 3798 3798
Lines 90682 90682
Branches 14271 14271
==========================================
+ Hits 55092 55102 +10
+ Misses 32093 32082 -11
- Partials 3497 3498 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8744-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 78204a09479b72603034b5a6cda309e02bf98e57
# Push it to GitHub
git push --set-upstream origin backport/backport-8744-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…search-project#8744) * Revert back to using the official release of `vega-interpreter` Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR opensearch-project#8744 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 78204a0) Signed-off-by: Miki <miki@amazon.com>
* Revert back to using the official release of `vega-interpreter` (#8744) * Revert back to using the official release of `vega-interpreter` Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8744 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 78204a0) Signed-off-by: Miki <miki@amazon.com> * [CVE-2024-21538] Bump `cross-spawn` from 6.0.5 and 7.0.3 to 7.0.5 (#8882) * Bump `cross-spawn` from 6.0.5 and 7.0.3 to 7.0.5 Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8882 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d94fad2) Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
manual backport was merged into 2.x. |
Description
Revert back to using the official release of
vega-interpreter
Note: Our PR was merged into their 1.0.5 release so we can stop using the patched version.
Changelog
vega-interpreter
Check List
yarn test:jest
yarn test:jest_integration