[Backport 2.x] [Discover] UI Updates to Dataset Configurator #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](/~https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* adding UI changes Signed-off-by: Sean Li <lnse@amazon.com> * addressing comments Signed-off-by: Sean Li <lnse@amazon.com> * fixing more bugs, adding no time field prop for unsupported languages Signed-off-by: Sean Li <lnse@amazon.com> * addressing comments Signed-off-by: Sean Li <lnse@amazon.com> * addressing comments Signed-off-by: Sean Li <lnse@amazon.com> * Changeset file for PR #8166 created/updated * adressing comments, renaming label Signed-off-by: Sean Li <lnse@amazon.com> * addressing comments, adding tests Signed-off-by: Sean Li <lnse@amazon.com> * updating snapshots Signed-off-by: Sean Li <lnse@amazon.com> * adding i18n translation for no time filter option Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3ae4cdc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
discover
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
sejli
approved these changes
Oct 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8526 +/- ##
=======================================
Coverage 61.02% 61.02%
=======================================
Files 3766 3766
Lines 89428 89435 +7
Branches 13992 13996 +4
=======================================
+ Hits 54573 54580 +7
+ Misses 31457 31456 -1
- Partials 3398 3399 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
reviewed
Oct 9, 2024
There was a problem hiding this comment.
code cov is dropping, could you check and add UT if needed? @sejli
LDrago27
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3ae4cdc from #8166.