Fix unprefixed i18n identifiers in examples #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
i18n-examples
branch
from
4bd1406 to
af7a3c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8412 +/- ##
==========================================
+ Coverage 60.92% 60.94% +0.01%
==========================================
Files 3750 3757 +7
Lines 89103 89265 +162
Branches 13925 13959 +34
==========================================
+ Hits 54285 54400 +115
- Misses 31442 31478 +36
- Partials 3376 3387 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
previously approved these changes
Oct 1, 2024
LDrago27
approved these changes
Oct 2, 2024
ashwin-pc
reviewed
Oct 2, 2024
Either they are a duplicate of another key with a different value, or they are not using the namespace for this folder. |
ashwin-pc
approved these changes
Oct 3, 2024
|
Lets make sure to add those to the linter rules. I can see this easily drift in future :) |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Fix unprefixed and duplicate i18n identifiers in examples Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8412 created/updated * Changeset file for PR #8412 created/updated * Changeset file for PR #8412 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2f541ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Fix unprefixed and duplicate i18n identifiers in examples * Changeset file for PR #8412 created/updated * Changeset file for PR #8412 created/updated * Changeset file for PR #8412 created/updated --------- (cherry picked from commit 2f541ff) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix unprefixed i18n identifiers in examples
Changelog
Check List
yarn test:jestyarn test:jest_integration