Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Update details panel UI in workspace create page #8375

Merged
merged 4 commits into from
Sep 30, 2024
Merged

[Workspace]Update details panel UI in workspace create page #8375

merged 4 commits into from
Sep 30, 2024

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 29, 2024 •
edited
Loading

Description

This PR is for updating details panel UI in workspace create page. Move the color, name and description input in the same panel like screenshot below.

Issues Resolved

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and go to workspace create page by bottom left menu
  • The workspace details panel should be displayed like screenshot above
  • The name, color and description field should work as expected

Changelog

  • feat: [Workspace]Update details panel UI in workspace create page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@wanglam
Update details panel UI in workspace create page
da0c9c9 
Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Sep 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (c1a349a) to head (b714df6).
Report is 161 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8375      +/-   ##
==========================================
- Coverage   60.93%   60.93%   -0.01%     
==========================================
  Files        3749     3750       +1     
  Lines       89038    89043       +5     
  Branches    13903    13906       +3     
==========================================
+ Hits        54251    54254       +3     
- Misses      31425    31426       +1     
- Partials     3362     3363       +1
Flag Coverage Δ
Linux_1 28.86% <100.00%> (+<0.01%) ⬆️
Linux_2 56.35% <ø> (ø)
Linux_3 37.75% <ø> (-0.01%) ⬇️
Linux_4 29.96% <ø> (ø)
Windows_1 28.87% <100.00%> (+<0.01%) ⬆️
Windows_2 56.30% <ø> (ø)
Windows_3 37.76% <ø> (ø)
Windows_4 29.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam marked this pull request as ready for review September 29, 2024 10:54
@wanglam wanglam requested a review from huyaboo as a code owner September 29, 2024 10:54
ruanyl
ruanyl approved these changes Sep 30, 2024
View reviewed changes
src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx
@@ -86,7 +76,7 @@ export const WorkspaceCreatorForm = (props: WorkspaceCreatorFormProps) => {

return (
<EuiFlexGroup className="workspaceCreateFormContainer">
<EuiFlexItem style={{ maxWidth: 768 }}>
<EuiFlexItem style={{ maxWidth: 848 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we avoid hard coded with?

@ruanyl ruanyl merged commit 71ab7bb into opensearch-project:main Sep 30, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2024
@github-actions @opensearch-changeset-bot
[Workspace]Update details panel UI in workspace create page (#8375)
207cb78 
* Update details panel UI in workspace create page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8375 created/updated

* Fix details panel title not rendered

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 71ab7bb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 1, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Oct 1, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace]Update details panel UI in workspace create page (#8375) (#…
e5baae2 
…8416)

* Update details panel UI in workspace create page



* Changeset file for PR #8375 created/updated

* Fix details panel title not rendered



---------



(cherry picked from commit 71ab7bb)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @SuZhou-Joe
[Workspace]Update details panel UI in workspace create page (opensear…
26c817b 
…ch-project#8375) (opensearch-project#8416)

* Update details panel UI in workspace create page



* Changeset file for PR opensearch-project#8375 created/updated

* Fix details panel title not rendered



---------



(cherry picked from commit 71ab7bb)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x v2.18.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanglam @ruanyl @SuZhou-Joe @ananzh