Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update recent items icon from SVG to react component #7478

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Jul 25, 2024

Description

In recent items component of chrome service, we will import SVG file directly. Some external plugins use chrome service and run tests will throw error( /~https://github.com/opensearch-project/dashboards-flow-framework/actions/runs/10079628727/job/27867403933?pr=240) if they doesn't configure svg in jest config./~https://github.com/opensearch-project/dashboards-flow-framework/blob/main/test/jest.config.js

Testing the changes

Changelog

  • fix: update recent items icon from SVG to react component

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (f872b02) to head (d17d9e4).
Report is 10 commits behind head on main.

Files Patch % Lines
...core/public/chrome/ui/header/recent_items_icon.tsx 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f872b02) and HEAD (d17d9e4). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f872b02) HEAD (d17d9e4)
Linux_4 1 0
Linux_3 1 0
Windows_3 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7478      +/-   ##
==========================================
- Coverage   64.13%   54.20%   -9.93%     
==========================================
  Files        3614     3252     -362     
  Lines       78680    70659    -8021     
  Branches    12432    10828    -1604     
==========================================
- Hits        50463    38303   -12160     
- Misses      25167    30335    +5168     
+ Partials     3050     2021    -1029     
Flag Coverage Δ
Linux_1 30.76% <50.00%> (-0.15%) ⬇️
Linux_2 55.60% <50.00%> (+0.02%) ⬆️
Linux_3 ?
Linux_4 ?
Windows_1 30.77% <50.00%> (-0.15%) ⬇️
Windows_2 55.55% <50.00%> (+0.02%) ⬆️
Windows_3 ?
Windows_4 31.49% <50.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 236488d into opensearch-project:main Jul 25, 2024
46 of 74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
* update recent items icon from svg to react component

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7478 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 236488d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
* update recent items icon from svg to react component

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7478 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 236488d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
…-project#7478)

* update recent items icon from svg to react component

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#7478 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants