-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update recent items icon from SVG to react component #7478
Conversation
Signed-off-by: tygao <tygao@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7478 +/- ##
==========================================
- Coverage 64.13% 54.20% -9.93%
==========================================
Files 3614 3252 -362
Lines 78680 70659 -8021
Branches 12432 10828 -1604
==========================================
- Hits 50463 38303 -12160
- Misses 25167 30335 +5168
+ Partials 3050 2021 -1029
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* update recent items icon from svg to react component Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #7478 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 236488d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update recent items icon from svg to react component Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #7478 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 236488d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…-project#7478) * update recent items icon from svg to react component Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#7478 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
In recent items component of chrome service, we will import SVG file directly. Some external plugins use chrome service and run tests will throw error( /~https://github.com/opensearch-project/dashboards-flow-framework/actions/runs/10079628727/job/27867403933?pr=240) if they doesn't configure svg in jest config./~https://github.com/opensearch-project/dashboards-flow-framework/blob/main/test/jest.config.js
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration