[navigation-next] feat: add recent works in new homepage #7237

SuZhou-Joe · 2024-07-14T05:17:20Z

Description

Add recent works section in new home page.

Issues Resolved

Screenshot

Workspace enabled

20240720224051706.mp4

Workspace disabled

20240720224254539.mp4

Empty state

Testing the changes

Go to the advanced settings page to enable new home page.
Go to home page, you should see the recent items section is displayed in home page.

Changelog

feat: [navigation-next] add recent works in new homepage

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-07-14T05:34:25Z

Codecov Report

Attention: Patch coverage is 70.51282% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (e64de15) to head (9c7e0e6).

Files	Patch %	Lines
...nagement/public/management_section/recent_work.tsx	83.07%	6 Missing and 5 partials ⚠️
.../plugins/saved_objects_management/public/plugin.ts	0.00%	5 Missing ⚠️
...rc/plugins/home/public/application/home_render.tsx	0.00%	4 Missing ⚠️
...ome/recently_accessed/recently_accessed_service.ts	0.00%	0 Missing and 1 partial ⚠️
...application/utils/use/use_saved_vis_builder_vis.ts	0.00%	1 Missing ⚠️
..._builder/public/saved_visualizations/_saved_vis.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7237   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files        3520     3521    +1     
  Lines       69700    69777   +77     
  Branches    11376    11390   +14     
=======================================
+ Hits        47189    47246   +57     
- Misses      19716    19730   +14     
- Partials     2795     2801    +6

Flag	Coverage Δ
Linux_1	`33.15% <12.82%> (-0.04%)`	⬇️
Linux_2	`55.46% <0.00%> (-0.01%)`	⬇️
Linux_3	`43.24% <12.00%> (-0.08%)`	⬇️
Linux_4	`34.81% <72.00%> (+0.10%)`	⬆️
Windows_1	`33.17% <12.82%> (-0.04%)`	⬇️
Windows_2	`55.41% <0.00%> (-0.01%)`	⬇️
Windows_3	`43.26% <12.00%> (-0.07%)`	⬇️
Windows_4	`34.81% <72.00%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/content_management/public/components/section_render.tsx

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe · 2024-07-20T14:45:01Z

I haven't looked at this yet, but just wanted to call out that some tests were failing and code coverage for patch is much lower than target - have you taken a look at these?

Thanks, added some test to improve the code coverage.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

src/core/public/chrome/recently_accessed/recently_accessed_service.ts

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

src/plugins/saved_objects_management/public/management_section/recent_work.tsx

Hailong-am · 2024-07-21T15:16:22Z

src/plugins/saved_objects_management/public/management_section/recent_work.tsx

+    const savedObjects = recentAccessed
+      .filter((item) => item.meta?.type)


does this mean legacy recently view items are ignored?

Yes, because legacy items does not have viewed at, nor the type.

src/plugins/saved_objects_management/public/management_section/recent_work.tsx

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ananzh · 2024-07-22T15:01:32Z

@SuZhou-Joe could we first fix the failed tests? thx

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7237 created/updated * feat: remove the euispacer Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update empty state Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update i18n key Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 46afb96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Changeset file for PR #7237 created/updated * feat: remove the euispacer * feat: update empty state * feat: update i18n key * feat: update --------- (cherry picked from commit 46afb96) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Changeset file for PR #7237 created/updated * feat: remove the euispacer * feat: update empty state * feat: update i18n key * feat: update --------- (cherry picked from commit 46afb96) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d89447b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…) (#7381) * Changeset file for PR #7237 created/updated * feat: remove the euispacer * feat: update empty state * feat: update i18n key * feat: update --------- (cherry picked from commit 46afb96) (cherry picked from commit d89447b) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

SuZhou-Joe requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27 and virajsanghvi as code owners July 14, 2024 05:17

github-actions bot added all-star-contributor failed changeset labels Jul 14, 2024

opensearch-project deleted a comment from github-actions bot Jul 14, 2024

ruanyl reviewed Jul 15, 2024

View reviewed changes

src/plugins/content_management/public/components/section_render.tsx Outdated Show resolved Hide resolved

SuZhou-Joe marked this pull request as draft July 15, 2024 10:26

SuZhou-Joe force-pushed the feature/navigation-next branch 3 times, most recently from d73444b to eaf5fea Compare July 17, 2024 07:26

opensearch-project deleted a comment from github-actions bot Jul 20, 2024

SuZhou-Joe added 2 commits July 20, 2024 22:20

feat: update

8e15aa5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

f2e05c3

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

opensearch-project deleted a comment from github-actions bot Jul 20, 2024

SuZhou-Joe added backport 2.x navigation and removed failed changeset labels Jul 20, 2024

opensearch-project deleted a comment from github-actions bot Jul 20, 2024

opensearch-changeset-bot bot and others added 3 commits July 20, 2024 14:46

Changeset file for PR opensearch-project#7237 created/updated

a1b63e3

feat: remove the euispacer

2311419

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update empty state

701351c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl reviewed Jul 21, 2024

View reviewed changes

src/core/public/chrome/recently_accessed/recently_accessed_service.ts Outdated Show resolved Hide resolved

src/core/public/chrome/recently_accessed/recently_accessed_service.ts Outdated Show resolved Hide resolved

feat: update

55100c1

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl previously approved these changes Jul 21, 2024

View reviewed changes

feat: update

86d92f7

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe dismissed ruanyl’s stale review via 86d92f7 July 21, 2024 04:16

Hailong-am reviewed Jul 21, 2024

View reviewed changes

feat: update i18n key

f022a30

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added 2 commits July 22, 2024 23:06

Merge branch 'main' into feature/recent-items-next

bb14511

feat: update

9c7e0e6

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl approved these changes Jul 22, 2024

View reviewed changes

ananzh approved these changes Jul 22, 2024

View reviewed changes

SuZhou-Joe merged commit 46afb96 into opensearch-project:main Jul 22, 2024
67 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 22, 2024

[Backport 2.x] [navigation-next] feat: add recent works in new homepage #7362

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation-next] feat: add recent works in new homepage #7237

[navigation-next] feat: add recent works in new homepage #7237

SuZhou-Joe commented Jul 14, 2024 •

edited

Loading

codecov bot commented Jul 14, 2024 •

edited

Loading

SuZhou-Joe commented Jul 20, 2024

Hailong-am Jul 21, 2024

SuZhou-Joe Jul 22, 2024

ananzh commented Jul 22, 2024

		const savedObjects = recentAccessed
		.filter((item) => item.meta?.type)

[navigation-next] feat: add recent works in new homepage #7237

[navigation-next] feat: add recent works in new homepage #7237

Conversation

SuZhou-Joe commented Jul 14, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Workspace enabled

Workspace disabled

Empty state

Testing the changes

Changelog

Check List

codecov bot commented Jul 14, 2024 • edited Loading

Codecov Report

SuZhou-Joe commented Jul 20, 2024

Hailong-am Jul 21, 2024

Choose a reason for hiding this comment

SuZhou-Joe Jul 22, 2024

Choose a reason for hiding this comment

ananzh commented Jul 22, 2024

SuZhou-Joe commented Jul 14, 2024 •

edited

Loading

codecov bot commented Jul 14, 2024 •

edited

Loading