Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove unused import and property #6879

Merged
merged 2 commits into from
May 31, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented May 31, 2024

Description

This change fix the bug introduced by #6827 which added new prop but then removed.

Issues Resolved

fixes #6878

Screenshot

data source view example

Screenshot 2024-05-31 at 8 48 16 AM

Testing the changes

After the fix, running dashboards locally and the error reported went away, data source view example renders successfully

Changelog

  • fix: remove unused import and property which broke compilation

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.12%. Comparing base (e2c0df2) to head (0dcb846).

Current head 0dcb846 differs from pull request most recent head 7202326

Please upload reports for the commit 7202326 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6879       +/-   ##
===========================================
- Coverage   67.43%   55.12%   -12.31%     
===========================================
  Files        3444     1204     -2240     
  Lines       67834    24625    -43209     
  Branches    11031     4168     -6863     
===========================================
- Hits        45741    13574    -32167     
+ Misses      19427    10400     -9027     
+ Partials     2666      651     -2015     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.12% <ø> (ø)
Linux_3 ?
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flyingliuhub
Copy link
Member

LGTM

@Flyingliuhub
Copy link
Member

do we need to backport 2.x?

@BionIT BionIT merged commit f7e10a9 into opensearch-project:main May 31, 2024
69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2024
* remove unused import and prop

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6879 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f7e10a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6879-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7e10a9b7b1e768170240fffd15d628f2e49cdfb
# Push it to GitHub
git push --set-upstream origin backport/backport-6879-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6879-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6879-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7e10a9b7b1e768170240fffd15d628f2e49cdfb
# Push it to GitHub
git push --set-upstream origin backport/backport-6879-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6879-to-2.x.

BionIT added a commit to BionIT/OpenSearch-Dashboards that referenced this pull request May 31, 2024
* remove unused import and prop

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR opensearch-project#6879 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
BionIT added a commit that referenced this pull request May 31, 2024
* remove unused import and prop



* Changeset file for PR #6879 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
* remove unused import and prop

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR opensearch-project#6879 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the multiple datasource multiple datasource project label Jun 7, 2024
@zhongnansu zhongnansu mentioned this pull request Jun 11, 2024
7 tasks
@zhongnansu zhongnansu added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor backport 2.x bug Something isn't working multiple datasource multiple datasource project v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] data_source_view crashes OSD when calling node scripts/build_opensearch_dashboards_platform_plugins.js
6 participants