Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Discover] Data selector enhancement #6691

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[Backport 2.x] [Discover] Data selector enhancement #6691

merged 1 commit into from
Apr 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 42166d0 from #6571.

@github-actions
[Discover] Data selector enhancement (#6571)
640d0eb 
* datasource and service refactoring

Signed-off-by: Eric <menwe@amazon.com>

* datasource enhancement and refactoring

Signed-off-by: Eric <menwe@amazon.com>

* datasource selectable consolidation and refactoring

Signed-off-by: Eric <menwe@amazon.com>

* add in memory cache with refresh

Signed-off-by: Eric <menwe@amazon.com>

* move refresh to right side

Signed-off-by: Eric <menwe@amazon.com>

* renaming

Signed-off-by: Eric <menwe@amazon.com>

* update default datasource tests

Signed-off-by: Eric <menwe@amazon.com>

* added more tests for default datasource

Signed-off-by: Eric <menwe@amazon.com>

* update selector tests

Signed-off-by: Eric <menwe@amazon.com>

* update changelog

Signed-off-by: Eric <menwe@amazon.com>

* fix data source service tests

Signed-off-by: Eric <menwe@amazon.com>

* add and update tests for datasource service

Signed-off-by: Eric <menwe@amazon.com>

* add more data source service tests

Signed-off-by: Eric <menwe@amazon.com>

* fix sidebar tests

Signed-off-by: Eric <menwe@amazon.com>

* add to change log yml

Signed-off-by: Eric <menwe@amazon.com>

* address comments along with more tests

Signed-off-by: Eric <menwe@amazon.com>

* add test subject

Signed-off-by: Eric <menwe@amazon.com>

* reference from correct type path

Signed-off-by: Eric <menwe@amazon.com>

* correct text

Signed-off-by: Eric <menwe@amazon.com>

* minor change - remove yet used displayOrder

Signed-off-by: Eric <menwe@amazon.com>

* remove from changelog as having fragments already

Signed-off-by: Eric <menwe@amazon.com>

* use expanded name

Signed-off-by: Eric <menwe@amazon.com>

* fix one test

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit 42166d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports repeat-contributor data explorer Issues related to the Data Explorer project v2.14.0 labels Apr 30, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.63158% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 67.74%. Comparing base (521b943) to head (640d0eb).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
..._sources/datasource_services/datasource_service.ts 59.25% 9 Missing and 2 partials ⚠️
...rces/datasource_selector/datasource_selectable.tsx 78.78% 3 Missing and 4 partials ⚠️
src/plugins/data/public/plugin.ts 0.00% 4 Missing ⚠️
...lugins/discover/public/__mock__/index.test.mock.ts 25.00% 3 Missing ⚠️
.../data_explorer/public/components/sidebar/index.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #6691   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files        3412     3414    +2     
  Lines       66875    66911   +36     
  Branches    10864    10868    +4     
=======================================
+ Hits        45305    45330   +25     
- Misses      18932    18943   +11     
  Partials     2638     2638
Flag Coverage Δ
Linux_1 33.19% <20.68%> (-0.01%) ⬇️
Linux_2 55.66% <ø> (ø)
Linux_3 45.27% <72.63%> (+0.02%) ⬆️
Linux_4 35.00% <20.68%> (-0.01%) ⬇️
Windows_1 33.22% <20.68%> (-0.01%) ⬇️
Windows_2 55.63% <ø> (ø)
Windows_3 45.28% <72.63%> (+0.02%) ⬆️
Windows_4 35.00% <20.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit 4d14b60 into 2.x Apr 30, 2024
92 of 93 checks passed
@github-actions github-actions bot deleted the backport/backport-6571-to-2.x branch April 30, 2024 22:43
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@github-actions
[Discover] Data selector enhancement (#6571) (#6691)
ed10ca1 
* datasource and service refactoring

* datasource enhancement and refactoring

* datasource selectable consolidation and refactoring

* add in memory cache with refresh

* move refresh to right side

* renaming

* update default datasource tests

* added more tests for default datasource

* update selector tests

* update changelog

* fix data source service tests

* add and update tests for datasource service

* add more data source service tests

* fix sidebar tests

* add to change log yml

* address comments along with more tests

* add test subject

* reference from correct type path

* correct text

* minor change - remove yet used displayOrder

* remove from changelog as having fragments already

* use expanded name

* fix one test

---------

(cherry picked from commit 42166d0)

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4d14b60)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 30, 2024
Merged
ananzh pushed a commit that referenced this pull request Apr 30, 2024
@opensearch-trigger-bot @github-actions
[Discover] Data selector enhancement (#6571) (#6691) (#6692)
1dc54ec 
* datasource and service refactoring

* datasource enhancement and refactoring

* datasource selectable consolidation and refactoring

* add in memory cache with refresh

* move refresh to right side

* renaming

* update default datasource tests

* added more tests for default datasource

* update selector tests

* update changelog

* fix data source service tests

* add and update tests for datasource service

* add more data source service tests

* fix sidebar tests

* add to change log yml

* address comments along with more tests

* add test subject

* reference from correct type path

* correct text

* minor change - remove yet used displayOrder

* remove from changelog as having fragments already

* use expanded name

* fix one test

---------

(cherry picked from commit 42166d0)





(cherry picked from commit 4d14b60)

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT pushed a commit to BionIT/OpenSearch-Dashboards that referenced this pull request May 3, 2024
@opensearch-trigger-bot @github-actions @BionIT
[Discover] Data selector enhancement (opensearch-project#6571) (opens…
50dae47 
…earch-project#6691) (opensearch-project#6692)

* datasource and service refactoring

* datasource enhancement and refactoring

* datasource selectable consolidation and refactoring

* add in memory cache with refresh

* move refresh to right side

* renaming

* update default datasource tests

* added more tests for default datasource

* update selector tests

* update changelog

* fix data source service tests

* add and update tests for datasource service

* add more data source service tests

* fix sidebar tests

* add to change log yml

* address comments along with more tests

* add test subject

* reference from correct type path

* correct text

* minor change - remove yet used displayOrder

* remove from changelog as having fragments already

* use expanded name

* fix one test

---------

(cherry picked from commit 42166d0)





(cherry picked from commit 4d14b60)

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@Flyingliuhub Flyingliuhub Flyingliuhub approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports backport 2.14 data explorer Issues related to the Data Explorer project repeat-contributor v2.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwin-pc @Flyingliuhub @kavilla