-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Next Theme] Make next
theme the default
#4887
Conversation
* Make v8 theme default Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Miki <miki@amazon.com> (cherry picked from commit 9d7f576) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## 2.x #4887 +/- ##
==========================================
- Coverage 66.46% 66.44% -0.03%
==========================================
Files 3396 3396
Lines 64847 64847
Branches 10356 10356
==========================================
- Hits 43100 43086 -14
- Misses 19190 19203 +13
- Partials 2557 2558 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to check do we need to add the migration to force people onto this if their config has this set?
I think we cleared it out anyways in a previously release so it's likely an edge case.
This may be something we need to do. I'll test it out later this afternoon. |
Backport 9d7f576 from #4854.