-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New App Shell #13
New App Shell #13
Conversation
…re into feature/app-shell
Starting into it. This might involve a tricky rebase, but do you think you could merge the other repos in in a way that preserves their histories, for example using lerna import? |
I'd love to avoid that. Its unnecessary work imho - if you want to do it then please go ahead. Otherwise, I'd just archive the other repos (if one really needs to know the past the old repos are still there). (Through the squash merge we would lose the history anyway.) |
Awesome work. Just requesting those four minor changes above. |
All done! |
Great work Florian! |
Brings the new app shell to live.
@openmrs/esm-module-config
to@openmrs/esm-config
@openmrs/esm-api
,@openmrs/esm-styleguide
,@openmrs/esm-error-handling
into theesm-core
repositoryesm-api
), which allows store creation per esm (multiple if wanted), but already comes with a central one shared from the appThere's more to it. I'll demo everything tomorrow.