Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure repr workes with blank / fresh datasets #820

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

amueller
Copy link
Contributor

running create_dataset in jupyter was tricky because the repr failed afterwards.

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #820 into develop will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #820      +/-   ##
===========================================
+ Coverage    87.69%   88.02%   +0.33%     
===========================================
  Files           36       36              
  Lines         4234     4234              
===========================================
+ Hits          3713     3727      +14     
+ Misses         521      507      -14
Impacted Files Coverage Δ
openml/datasets/dataset.py 87.21% <100%> (+3.69%) ⬆️
openml/_api_calls.py 84.61% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b259a34...d554d5b. Read the comment docs.

@mfeurer mfeurer merged commit 3e14267 into openml:develop Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants