Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GET instead of POST for flow exist #1147

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Use GET instead of POST for flow exist #1147

merged 2 commits into from
Jun 28, 2022

Conversation

PGijsbers
Copy link
Collaborator

The flow/exist endpoint can be accessed with a GET request, which avoids requiring an API key. Particularly important for #1143

@mfeurer
Copy link
Collaborator

mfeurer commented Jun 27, 2022

Hey @PGijsbers did you mean to request a review from me? You assigned me to this PR, which I don't know what to do about.

@PGijsbers
Copy link
Collaborator Author

Sorry, yes I meant to tag you as reviewer not assignee.

@PGijsbers PGijsbers requested a review from mfeurer June 28, 2022 07:23
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard to say with all the failing tests, but the change itself looks good to me.

@PGijsbers
Copy link
Collaborator Author

I did try it locally, but the loss of a functional test server is a regrettable indeed.

@PGijsbers PGijsbers merged commit c911d6d into develop Jun 28, 2022
@PGijsbers PGijsbers deleted the fix-check-flow branch June 28, 2022 07:38
PGijsbers added a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants