Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346302: Fix logging breaking Nashorn initialization #20

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Dec 16, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • JDK-8346302: Fix logging breaking Nashorn initialization (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/nashorn.git pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.org/nashorn.git pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/nashorn/pull/20.diff

@szegedi
Copy link
Collaborator Author

szegedi commented Dec 16, 2024

@ppkarwasz FYI

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@szegedi szegedi changed the title An intermediate logging fix 8346302: Fix logging breaking Nashorn initialization Dec 16, 2024
@openjdk openjdk bot added the rfr label Dec 16, 2024
@szegedi
Copy link
Collaborator Author

szegedi commented Dec 16, 2024

Seems like it works: de13268#commitcomment-150415635

@szegedi szegedi merged commit 2c09a25 into openjdk:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant