Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294560: assertion raised in newBuiltinSwitchPoint #18

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Dec 14, 2022

Fixes the problem by making switchpoint creation safe under concurrent use.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • JDK-8294560: assertion raised in newBuiltinSwitchPoint

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/nashorn pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/nashorn pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/nashorn/pull/18.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 14, 2022
@szegedi
Copy link
Collaborator Author

szegedi commented Feb 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 7, 2023

@szegedi This pull request has not yet been marked as ready for integration.

@szegedi
Copy link
Collaborator Author

szegedi commented Feb 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 7, 2023

@szegedi This pull request has not yet been marked as ready for integration.

@szegedi szegedi merged commit 6b39923 into openjdk:main Feb 7, 2023
@szegedi szegedi deleted the switchpoint-assert branch February 7, 2023 18:29
szegedi added a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant