fpnew: Fix f2i cast edge cases #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-by: Noah Huetter <noah.huetter@axelera.ai>
|
This bug appears when any float to int cast rounds the result up to positive |
|
I ❤️ Bug fixing |
anga93
pushed a commit
to yvantor/fpnew
that referenced
this pull request
Nov 21, 2022
Reviewed-by: Noah Huetter <noah.huetter@axelera.ai> Co-authored-by: Stefan Mach <stefan.mach@axelera.ai>
msyksphinz-self
pushed a commit
to msyksphinz-self/fpnew
that referenced
this pull request
Oct 21, 2023
Reviewed-by: Noah Huetter <noah.huetter@axelera.ai> Co-authored-by: Stefan Mach <stefan.mach@axelera.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge-case where an overflow before rounding causes the integer output to overflow/wrap instead of clip.
The bug was found when converting the float
127.5to anINT8withRNErounding. 127.5 is converted to 128 before rounding which resulted in the output0x80instead of0x7f.Original fix by @stmach.
Reviewed-by: Noah Huetter noah.huetter@axelera.ai