[RISCV][CV-SIMD] Fix the immediate type in the shuffle pseudo expansion. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate operand of the 'sci' variant of the shuffle instructions of the xcvsimd extension is always zero-extended. This commit fixes the expansion of the pseudo shuffle instruction by adding an unsigned immediate parameter (hence zero-extended) rather then a signed one as it was before.
|
Ready to merge and close the previous one if the tests look good |
|
Tests look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate operand of the 'sci' variant of the shuffle instructions of the xcvsimd extension is always zero-extended.
This commit fixes the expansion of the pseudo shuffle instruction by adding an unsigned immediate parameter (hence zero-extended) rather then a signed one as it was before.
This patch is a reboot of the previous PR #87
It is just a cleaner approach than a merge commit. The original change is good and copied untouched here.