Adding validation on channel id when adding a channel #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Signed-off-by: Yannick Schaus <github@schaus.net>
ghys
approved these changes
Jan 13, 2021
ghys
pushed a commit
that referenced
this pull request
Jan 13, 2021
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
ghys
added
bug
|
Sorry for the indentation, was a quick and dirty done in notepad. Won't happen in the future. The adjustment you made to the dialog text is not completely accurate, you can also use "_" as far as I can tell without issues. Also can close the MQTT bug listed above, this fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validation and warnings when adding a channel with an invalid name as the Unique ID could have been blank which would fail and not let the user know.
This change would only allow alphanumeric characters and numbers as well as an underscore character. That should keep it valid when it's added.