Added thermostatTemperatureSetpointHigh and ...Low to Metadadata UI list #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta UI list Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
|
Just a side note: The coffee maker issue is also documented here: openhab/openhab-google-assistant#154 |
ghys
approved these changes
Dec 29, 2020
crnjan
added a commit
to crnjan/openhab-webui
that referenced
this pull request
Jan 6, 2021
* master: Take all door subclasses in door location glance badge (openhab#727) [habpanel] Remove ItemStateEvent detection (openhab#737) Update license headers to 2021 (openhab#739) Fix openhab#714 - Sort popup dialogs by name and jump to selected item on open (openhab#724) Fix openhab#538 - Do not concatenate search for items (openhab#726) Fix openhab#722 - Show current GA metadata when editing (openhab#723) Fix openhab#720 - Fix various problems with google assistant metadata UI (openhab#721) Fix openhab#684 - Allow diacritics in search bars (openhab#718) CSP: allow blob: URLs (openhab#698) Apply Spotless (openhab#680) [unleash-maven-plugin] Preparation for next development cycle.
ghys
pushed a commit
to ghys/openhab-webui
that referenced
this pull request
Jan 11, 2021
… UI (openhab#721) Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
ghys
added
patch
kaikreuzer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various problems with the google assistant metadata UI, including #720. I took all the data directly from the source, not relying on the documentation (because it is wrong in some minor places).
thermostatTemperatureSetpointHighandthermostatTemperatureSetpointLow(fixes Google Assistant metadata missing optional thermostat items #720)CoffeeMakertoCoffee_Maker(yes, it has to be this inconsistent to work unfortunately, thanks Google...)protocolsandtokensparameters forCameraspeedtospeedsand add parameterlang(Fan)structureHint(all items) because it is implemented in the assistant binding and roomHint is also in the UI alreadyinvertedfor Switch, Outlet, CoffeeMaker, WaterHeater, Fireplace, Valve, Sprinkler, Vacuum, Lock, SecuritySystemthermostatTemperatureRange(Thermostat)Signed-off-by: Eiko Wagenknecht eiko.wagenknecht@web.de