Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home page: Hide tab bar if all model tabs are hidden #2291

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Home page: Hide tab bar if all model tabs are hidden #2291

merged 1 commit into from
Jan 27, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jan 27, 2024 •
edited
Loading

If all model tabs are hidden, the tab bar has only one entry and therefore there is no need to display it.

@florian-h05
Home page: Hide tab bar if all model tabs are hidden
64f1e88 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner January 27, 2024 16:15
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jan 27, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jan 27, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 27, 2024

Job #1375: Bundle Size — 15.83MiB (~-0.01%).

64f1e88(current) vs 8b6b262 main#1374(baseline)

Warning

Bundle contains 16 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1375		      Baseline
Job #1374
Regression  Initial JS 1.89MiB(~+0.01%) 1.89MiB
No change  Initial CSS 609.81KiB 609.81KiB
Change  Cache Invalidation 93.97% 93.87%
No change  Chunks 217 217
No change  Assets 683 683
No change  Modules 3012 3012
No change  Duplicate Modules 170 170
No change  Duplicate Code 1.6% 1.6%
No change  Packages 152 152
No change  Duplicate Packages 16 16
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1375		      Baseline
Job #1374
Regression  JS 9.3MiB (~+0.01%) 9.3MiB
Improvement  Other 4.75MiB (~-0.01%) 4.75MiB
Not changed  CSS 861.35KiB 861.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1375 report View florian-h05:homepage-hide-tabbar... branch activity View project dashboard

@florian-h05 florian-h05 merged commit 4864f43 into openhab:main Jan 27, 2024
6 checks passed
@florian-h05 florian-h05 deleted the homepage-hide-tabbar-if-no-tabs branch January 27, 2024 16:35
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Feb 17, 2024
florian-h05 added a commit that referenced this pull request Feb 17, 2024
@florian-h05
Home page: Hide tab bar if all model tabs are hidden (#2291)
db6cf75 
If all model tabs are hidden, the tab bar has only one entry and
therefore there is no need to display it.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit 4864f43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05