Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Fix Buttongrid alignment on desktop #2260

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 8, 2024

Fixes #2259

@jimtng jimtng requested a review from a team as a code owner January 8, 2024 13:02
@jimtng jimtng marked this pull request as draft January 8, 2024 13:04
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the basicui-buttongrid-margin branch from 9fc2ff7 to 4022662 Compare January 8, 2024 14:05
@jimtng jimtng marked this pull request as ready for review January 8, 2024 14:06
@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Jan 8, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Jan 8, 2024

I will test and review.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is better than mine, thank you.

@lolodomo
Copy link
Contributor

Tested on PC with different browsers and on my Android phone and works perfectly.

@lolodomo lolodomo merged commit a7cf1a0 into openhab:main Jan 13, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jan 13, 2024
@jimtng jimtng deleted the basicui-buttongrid-margin branch January 14, 2024 05:37
lolodomo pushed a commit that referenced this pull request Jan 14, 2024
Fixes #2259

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@lolodomo
Copy link
Contributor

Cherry-picked in 4.1.x branch

@lolodomo lolodomo added the patch A PR that has been cherry-picked to a patch release branch label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BasicUI] Buttongrid alignment issue on the web browser
2 participants