-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] Allow setting persistence service for blocks #1903
Merged
florian-h05
merged 3 commits into
openhab:main
from
stefan-hoehn:blockly_persitence_service_support
Jun 12, 2023
Merged
[blockly] Allow setting persistence service for blocks #1903
florian-h05
merged 3 commits into
openhab:main
from
stefan-hoehn:blockly_persitence_service_support
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #1028: Bundle Size — 15.77MiB (+0.01%).Metrics (1 change)
Total size by type (2 changes)
|
florian-h05
reviewed
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just a few questions.
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-persistence.js
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-persistence.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-persistence.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-persistence.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-persistence.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
florian-h05
changed the title
[blockly] provide persistence type to blocks
[blockly] Provide persistence service to blocks
Jun 4, 2023
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
florian-h05
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
florian-h05
changed the title
[blockly] Provide persistence service to blocks
[blockly] Allow setting persistence service for blocks
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1625
Allows to provide the persistence type to persistence blocks
default can be provided instead of selecting a particular one (is backward compatible to old blocks)
Either item name or item can be provided (note that variables must have the item not the item name as the type of variables cannot be detected)