Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] Allow setting persistence service for blocks #1903

Merged

Conversation

stefan-hoehn
Copy link
Contributor

fixes #1625

Allows to provide the persistence type to persistence blocks
default can be provided instead of selecting a particular one (is backward compatible to old blocks)
Either item name or item can be provided (note that variables must have the item not the item name as the type of variables cannot be detected)

image

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner May 18, 2023 18:35
@relativeci
Copy link

relativeci bot commented May 18, 2023

Job #1028: Bundle Size — 15.77MiB (+0.01%).

9d16372(current) vs c131139 main#1027(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1028
     Baseline
Job #1027
Initial JS 1.73MiB(-0.03%) 1.73MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.95%
Chunks 219 219
Assets 689 689
Modules 1720 1720
Duplicate Modules 85 85
Duplicate Code 1.72% 1.72%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1028
     Baseline
Job #1027
CSS 858.62KiB 858.62KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.26MiB (+0.01%) 9.26MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (~+0.01%) 4.73MiB

View job #1028 reportView main branch activity

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few questions.

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jun 4, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Jun 4, 2023
@florian-h05 florian-h05 changed the title [blockly] provide persistence type to blocks [blockly] Provide persistence service to blocks Jun 4, 2023
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit c5f2a9f into openhab:main Jun 12, 2023
@florian-h05 florian-h05 deleted the blockly_persitence_service_support branch June 12, 2023 16:21
@florian-h05 florian-h05 changed the title [blockly] Provide persistence service to blocks [blockly] Allow setting persistence service for blocks Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[blockly] persistence add parameter for persistence service to persistence nodes
2 participants