Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] Add dictionary loop #1898

Merged
merged 2 commits into from
May 15, 2023

Conversation

stefan-hoehn
Copy link
Contributor

fixes #1711
This adds a new loop type which allows to iterate over a dictionary as follows

image

It allows to either pass a variable (trusted to be of type Dictionary) or a Dictionary-Block itself.

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner May 13, 2023 17:06
@relativeci
Copy link

relativeci bot commented May 13, 2023

Job #1004: Bundle Size — 15.77MiB (~+0.01%).

8644ccf(current) vs 9685f0f main#1003(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (2 changes)
                 Current
Job #1004
     Baseline
Job #1003
Initial JS 1.73MiB(-0.02%) 1.73MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.95%
Chunks 219 219
Assets 689 689
Modules 1720 1720
Duplicate Modules 85 85
Duplicate Code 1.72%(-0.58%) 1.73%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1004
     Baseline
Job #1003
CSS 858.62KiB 858.62KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (+0.01%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (~+0.01%) 4.73MiB

View job #1004 reportView main branch activity

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title [blockly] add dictionary loop [blockly] Add dictionary loop May 15, 2023
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels May 15, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone May 15, 2023
@florian-h05 florian-h05 merged commit ae4b729 into openhab:main May 15, 2023
@florian-h05 florian-h05 deleted the blockly_forloop_dictionary branch May 15, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockly Dictionary loop block with value and key from dictionary
2 participants