-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rulesWithTags to oh-repeater #1724
Conversation
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #788: Bundle Size — 16.25MiB (~+0.01%).Metrics (1 change)
Total size by type (2 changes)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, please have a look at my comments.
We should also keep in mind that this approach works fine if you are logged in as an admin user, but if you are logged out or only logged in as a regular user, this won't work because the /rest/rules
endpoint requires admin role.
We therefore need some way to access the scenes as unauthorized user, just as we can access the Items. This should be reported and discussed in openHAB core, because we need unauthorized access to scene rules.
I'd expect that we then have to adjust the REST endpoint, so I'd probably wait with merging this. IMO there is no value yet for the most users because they normally shouldn't be logged in as admin.
bundles/org.openhab.ui/web/src/assets/definitions/widgets/system/repeater.js
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/widgets/standard/list/default-list-item.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/widgets/system/oh-repeater.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Issue opened |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, and please fix the linting npm run lint:fix
.
If this is done, we are ready to merge this.
bundles/org.openhab.ui/web/src/components/widgets/system/oh-repeater.vue
Show resolved
Hide resolved
Core PR created by @J-N-K |
Let's wait for openhab/openhab-core#3392 before merging. |
It was merged just now 😉 |
@stefan-hoehn @ghys @florian-h05 @J-N-K @kaikreuzer |
fixes #1721 Add Scenes option to oh-repeater component
This PR adds the possibility to iterate over a list of rules queried via a tag.
For example it allows to create a list of Scenes via the oh-repeater by using the rulesTag = Scene and trigger the rule via a oh-button.
Example