Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-on configuration #1684

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix add-on configuration #1684

merged 3 commits into from
Feb 9, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 5, 2023

See #1351 (comment)

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K
Fix add-on configuration
f710be8 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K requested a review from a team as a code owner February 5, 2023 16:22
@relativeci
Copy link

relativeci bot commented Feb 5, 2023 •
edited
Loading

Job #754: Bundle Size — 15.97MiB (~+0.01%).

01a54f9(current) vs 9473d43 main#753(baseline)

Metrics (no changes)
                 Current
Job #754		      Baseline
Job #753
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.48% 90.48%
Chunks 218 218
Assets 688 688
Modules 2009 2009
Duplicate Modules 108 108
Duplicate Code 1.77% 1.77%
Packages 135 135
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #754		      Baseline
Job #753
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.01MiB (~+0.01%) 9.01MiB
Media 295.6KiB 295.6KiB
Other 4.61MiB (~+0.01%) 4.61MiB

View job #754 report View main branch activity

J-N-K added 2 commits February 5, 2023 20:31
@J-N-K
Fix more config
4351f33 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
fix saving config
cb129db 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K mentioned this pull request Feb 5, 2023
Merged
ghys
ghys approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys added bug Something isn't working main ui Main UI labels Feb 9, 2023
@ghys ghys added this to the 4.0 milestone Feb 9, 2023
@ghys ghys merged commit 189cb5f into openhab:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@J-N-K @ghys