Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment as accordion click through fixes #1407

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

tarag
Copy link
Contributor

@tarag tarag commented Jun 13, 2022

Fixes for click through custom widgets containing either oh-button or oh-knob used in equipment accordion list. Click through leads to both the accordion opening and the action on the widget upon user action.

tarag added 2 commits June 9, 2022 20:23
… accordion equipment widget (home page tabs).

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
…cordion equipment widget (home page tabs).

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag tarag requested a review from a team as a code owner June 13, 2022 10:34
@relativeci
Copy link

relativeci bot commented Jun 13, 2022

Job #417: Bundle Size — 10.74MB (~+0.01%).

10fee05 vs 57f5f7f

Changed metrics (1/10)
Metric Current Baseline
Initial JS 1.67MB(~+0.01%) 1.67MB
Changed assets by type (1/7)
            Current     Baseline
JS 8.69MB (~+0.01%) 8.69MB

View Job #417 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tarag bonus unrelated question: normally top-level accordion items should have a hand cursor and some highlighting (in desktop theme) when hovered, like https://v5.framework7.io/vue/accordion#examples or the Things' channel lists, but that's not the case for equipment accordions, is this intentional? It's kind of counterintuitive.

chrome_2022-06-14_20-10-00

@ghys ghys merged commit 7932719 into openhab:main Jun 14, 2022
@ghys ghys added bug Something isn't working main ui Main UI labels Jun 14, 2022
@ghys ghys added this to the 3.3 milestone Jun 14, 2022
@tarag
Copy link
Contributor Author

tarag commented Jun 15, 2022

LGTM, thanks!

Thanks for the merge!

@tarag bonus unrelated question: normally top-level accordion items should have a hand cursor and some highlighting (in desktop theme) when hovered, like https://v5.framework7.io/vue/accordion#examples or the Things' channel lists, but that's not the case for equipment accordions, is this intentional? It's kind of counterintuitive.

This is definitely not intentional and must have slipped through the copy of style from the original F7 widget. I'll try to have a look at it. I agree with you that some additional cueing of the fact that there are some items hidden would be good, also for mobile. But the pointer is a start.

By the way, I see that you use colour lights. I still couldn't find a way to avoid the click trough effect while clicking on the colour widget. I've not figured out how the events are handled in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants