Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas layout bug fixes and edition mode UI improvements #1393

Merged
merged 5 commits into from
May 20, 2022
Merged

Canvas layout bug fixes and edition mode UI improvements #1393

merged 5 commits into from
May 20, 2022

Conversation

tarag
Copy link
Contributor

@tarag tarag commented May 19, 2022

Runtime mode bug fixes:

  • prevent widget from snapping to grid upon action in runtime mode

Edition mode bug fixes:

  • fix cursor when hovering above drag handle or label
  • allow positioning widgets right on the border of canvas
  • popup menu always displayed on top of other widgets
  • prevent text selection of drag handle and menu button upon dragging of widget

Edition mode improvements:

  • display of optional widget id in edition
  • display size of widget when resizing
  • display position of widget when moving
  • allow multiple selection of widgets
  • allow moving widgets through arrow keys

tarag added 4 commits May 17, 2022 10:57
@tarag
Canvas item edition improvements/bug fixes.
4398d5e 
Display of optional id in edition.
Display of size/position during resize/drag action.
Temporarily promote active item on top for clarity and to avoid having popup menu hidden by other items.

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag
Fix bug where canvas items would snap to grid in run mode upon user i…
805d2c4 
…nteraction if grid is enabled.

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag
Allow positioning widgets on the borders of canvas layouts.
49844c1 
Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag
Multiple canvas items selection and moving.
414d8a3 
Selection using shift key, moving around via dragging or arrow keys.

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag tarag requested a review from a team as a code owner May 19, 2022 13:41
@relativeci
Copy link

relativeci bot commented May 19, 2022 •
edited
Loading

Job #400: Bundle Size — 10.71MB (~-0.01%).

55cafb2 vs 04c3d8d

Changed metrics (2/10)
Metric Current Baseline
Initial JS 1.67MB(~-0.01%) 1.67MB
Cache Invalidation 15.78% 29.06%
Changed assets by type (1/7)
            Current     Baseline
JS 8.65MB (~-0.01%) 8.65MB

View Job #400 report on app.relative-ci.com

@tarag
Removed stray logging call.
7bec813 
Signed-off-by: Gautier Taravella <tarag@mailbox.org>
ghys
ghys approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and seems to work well after a quick test. Canvas layouts are your creation anyways so I'll trust you!

@ghys ghys merged commit 7302a31 into openhab:main May 20, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels May 20, 2022
@ghys ghys added this to the 3.3 milestone May 20, 2022
@tarag tarag deleted the canvas-layout-tweaks branch May 23, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tarag @ghys