Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] new HomeKit group mapping editor #1317

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Feb 18, 2022

Complex HomeKit accessories like Thermostats or Fan with Lights are modelled as groups in openHAB and the users have to assign HomeKit characteristics to corresponding group members - openHAB items.

this can be done already today at item level, i.e. adding HomeKit metadata to items, one after another.
but an overview at group level was missing.

this PR adds editor at group level for HomeKit metadata so that user can map HomeKit characteristics to openHAB item on one screen.

it looks like this. The example shows Fan with Light.
It lists all characteristics supported by HomeKit for these accessory types. Mandatory are marked with *. User can select the openHAB group item for each characteristics. And press "Update group members" button on the top to add required HomeKit metadata to the openHAB items.

Group can be save also without this mapping and mapping can be done later at item level as well.

Overview
Screenshot 2022-02-18 at 11 14 29

Select OH item
Screenshot 2022-02-18 at 11 14 41

please review the code, UI design and wording especially thoroughly as im not a frontend or javascript developer.

Signed-off-by: Eugen Freiter freiter@gmx.de

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre requested a review from a team as a code owner February 18, 2022 10:01
@yfre yfre changed the title [MainUI] HomeKit group mapping [MainUI] new HomeKit group mapping editor Feb 18, 2022
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@relativeci
Copy link

relativeci bot commented Feb 18, 2022

Job #352: Bundle Size — 10.69MB (+0.05%).

d6420b2 vs d042875

Changed metrics (1/8)
Metric Current Baseline
Initial JS 1.67MB(-0.04%) 1.67MB
Changed assets by type (1/7)
            Current     Baseline
JS 8.64MB (+0.06%) 8.63MB

View Job #352 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, glad to have some HomeKit love in the UI - I have nothing to say except "great work"!

@ghys ghys merged commit da7cfce into openhab:main Mar 3, 2022
@ghys ghys added this to the 3.3 milestone May 1, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants