Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small bug in widget mixin #1013

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix small bug in widget mixin #1013

merged 1 commit into from
Apr 22, 2021

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Apr 20, 2021

fix a small bug in widget-mixin, introduced by #979, ocurring when there's no context available (which happened regularly for me with oh-icon)

Signed-off-by: Hubert Nusser <hubsif@gmx.de>
@hubsif hubsif requested a review from a team as a code owner April 20, 2021 19:19
@relativeci
Copy link

relativeci bot commented Apr 20, 2021

Job #81: Bundle Size — 10.45MB (~-0.01%).

e100398 vs ae2cba4

Changed metrics (3/8)
Metric Current Baseline
Initial JS 1.61MB(-0.04%) 1.61MB
Cache Invalidation 16.28% 16.27%
Modules 1442(-0.07%) 1443
Changed assets by type (1/7)
            Current     Baseline
JS 8.12MB (~-0.01%) 8.12MB

View Job #81 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys added bug Something isn't working main ui Main UI labels Apr 22, 2021
@ghys ghys added this to the 3.1 milestone Apr 22, 2021
@ghys ghys merged commit 8040f28 into openhab:main Apr 22, 2021
hubsif added a commit to hubsif/openhab-webui that referenced this pull request May 6, 2021
Signed-off-by: Hubert Nusser <hubsif@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants